Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd: remove deprecated command charon create-cluster #550

Closed
xenowits opened this issue May 17, 2022 · 0 comments · Fixed by #551
Closed

cmd: remove deprecated command charon create-cluster #550

xenowits opened this issue May 17, 2022 · 0 comments · Fixed by #551
Assignees
@dB2510

Comments

@xenowits
Copy link
Contributor

Problem to be solved

The command charon create-cluster was restructured to charon create cluster. To ensure backwards compatibility, the deprecated code (newCreateClusterCmd) was not removed and a new function (newCreateClusterCmdNew) was added. See cmd/createcluster.go.

Proposed solution

  1. Update charon docker-compose to use the new command, ie, charon create cluster.
  2. Refactor to remove the old function.
@dB2510 dB2510 self-assigned this May 17, 2022
@dB2510 dB2510 mentioned this issue May 17, 2022
Merged
@dB2510 dB2510 linked a pull request May 17, 2022 that will close this issue
cmd: remove deprecated commands #551
Merged
obol-bulldozer bot pushed a commit that referenced this issue May 17, 2022
@dB2510
cmd: remove deprecated commands (#551)
8f073a8 
Refactors create command, removing deprecated cmds

category: refactor
ticket: #550
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dB2510 dB2510

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmd: remove deprecated commands ObolNetwork/charon
2 participants
@dB2510 @xenowits