cmd: remove deprecated commands #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #551 +/- ##
==========================================
+ Coverage 54.73% 55.09% +0.36%
==========================================
Files 92 91 -1
Lines 8589 8538 -51
==========================================
+ Hits 4701 4704 +3
+ Misses 3260 3208 -52
+ Partials 628 626 -2
Continue to review full report at Codecov.
|
xenowits
approved these changes
May 17, 2022
| @@ -43,17 +43,13 @@ func New() *cobra.Command { | |||
| return newRootCmd( | |||
| newVersionCmd(runVersionCmd), | |||
| newEnrCmd(runNewENR), | |||
| // TODO(dhruv): remove genp2pkey command once charon-docker-compose and docs are updated | |||
There was a problem hiding this comment.
leolara
approved these changes
May 17, 2022
dB2510
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors create command, removing deprecated cmds
category: refactor
ticket: #550