Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Definition hash log is in hex but in the file it is in b64 #753

Closed
OisinKyne opened this issue Jun 29, 2022 · 0 comments · Fixed by #756
Closed

Definition hash log is in hex but in the file it is in b64 #753

OisinKyne opened this issue Jun 29, 2022 · 0 comments · Fixed by #756
Assignees
@dB2510

Comments

@OisinKyne
Copy link
Contributor

Problem to be solved

At startup we have a log like 14:40:32.282 INFO dkg Connecting to peers... {"definition_hash": "0xf06038db86f54b2c064877cc92df34df613eef2103cd08e6e12447e65a729e87"} but the corresponding file has hash "definition_hash": "8GA424b1SywGSHfMkt8032E+7yEDzQjm4SRH5lpynoc="

Proposed solution

Change the log to be base64 for easy comparison

Out of Scope

If there is anything to highlight as out of scope for this issue, please outline it here.
@dB2510 dB2510 mentioned this issue Jun 30, 2022
Merged
@dB2510 dB2510 linked a pull request Jun 30, 2022 that will close this issue
dkg: replace hex with base64 for definition_hash #756
Merged
@dB2510 dB2510 self-assigned this Jun 30, 2022
obol-bulldozer bot pushed a commit that referenced this issue Jul 1, 2022
@dB2510
dkg: replace hex with base64 for definition_hash (#756)
f6b5361 
Replace hex string to base64 string for definition_hash in dkg logs.

category: refactor
ticket: #753
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dB2510 dB2510

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dkg: replace hex with base64 for definition_hash ObolNetwork/charon
2 participants
@OisinKyne @dB2510