Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth2exp: add CalculateCommitteeSubscriptionResponse function #1098

Merged
merged 7 commits into from
Sep 9, 2022

Conversation

xenowits
Copy link
Contributor

@xenowits xenowits commented Sep 8, 2022

Adds CalculateCommitteeSubscriptionResponse function to eth2exp/attagg.go that calculates is_aggregator and returns a BeaconCommitteeSubscriptionResponse.

category: feature
ticket: #1091

@xenowits xenowits marked this pull request as draft September 8, 2022 06:58
@xenowits xenowits changed the title eth2exp: Add CalculateCommitteeSubscriptionResponse function eth2exp: add CalculateCommitteeSubscriptionResponse function Sep 8, 2022
@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #1098 (d362841) into main (46665e2) will decrease coverage by 0.26%.
The diff coverage is 56.71%.

❗ Current head d362841 differs from pull request most recent head 68bf938. Consider uploading reports for the commit 68bf938 to get more accurate results

@@            Coverage Diff             @@
##             main    #1098      +/-   ##
==========================================
- Coverage   53.51%   53.25%   -0.27%     
==========================================
  Files         127      128       +1     
  Lines       14348    14486     +138     
==========================================
+ Hits         7679     7715      +36     
- Misses       5571     5665      +94     
- Partials     1098     1106       +8     
Impacted Files Coverage Δ
testutil/beaconmock/beaconmock.go 59.34% <0.00%> (-2.73%) ⬇️
testutil/beaconmock/server.go 54.47% <ø> (ø)
eth2util/eth2exp/attagg.go 22.58% <52.83%> (ø)
eth2util/hash.go 88.00% <100.00%> (+8.00%) ⬆️
core/scheduler/scheduler.go 73.49% <0.00%> (-0.55%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@corverroos corverroos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't reinvent the wheel, use eth2client

eth2util/eth2exp/attagg.go Outdated Show resolved Hide resolved
eth2util/eth2exp/attagg.go Outdated Show resolved Hide resolved
eth2util/eth2exp/attagg.go Outdated Show resolved Hide resolved
eth2util/eth2exp/attagg.go Outdated Show resolved Hide resolved
eth2util/hash.go Outdated Show resolved Hide resolved
eth2util/hash.go Outdated Show resolved Hide resolved
eth2util/hash.go Outdated Show resolved Hide resolved
eth2util/eth2exp/attagg_internal_test.go Outdated Show resolved Hide resolved
@xenowits
Copy link
Contributor Author

xenowits commented Sep 8, 2022

Don't reinvent the wheel, use eth2client

Yeah sorry, my bad smh

eth2util/hash.go Outdated Show resolved Hide resolved
@xenowits xenowits marked this pull request as ready for review September 9, 2022 10:46
@xenowits xenowits force-pushed the xenowits/calc-comm-sub-response branch from 6a0b442 to d362841 Compare September 9, 2022 10:52
eth2util/eth2exp/attagg.go Show resolved Hide resolved
eth2util/eth2exp/attagg.go Outdated Show resolved Hide resolved
eth2util/eth2exp/attagg.go Outdated Show resolved Hide resolved
eth2util/eth2exp/attagg.go Outdated Show resolved Hide resolved
eth2util/eth2exp/attagg.go Outdated Show resolved Hide resolved
eth2util/eth2exp/attagg_test.go Outdated Show resolved Hide resolved
eth2util/eth2exp/attagg_test.go Outdated Show resolved Hide resolved
eth2util/hash_test.go Outdated Show resolved Hide resolved
testutil/beaconmock/server.go Show resolved Hide resolved
eth2util/hash.go Outdated Show resolved Hide resolved
@xenowits xenowits added the merge when ready Indicates bulldozer bot may merge when all checks pass label Sep 9, 2022
@obol-bulldozer obol-bulldozer bot merged commit 6925c40 into main Sep 9, 2022
@obol-bulldozer obol-bulldozer bot deleted the xenowits/calc-comm-sub-response branch September 9, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants