Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/createdkg: add existing cluster definition check #1111

Merged
merged 1 commit into from
Sep 11, 2022

Conversation

dB2510
Copy link
Contributor

@dB2510 dB2510 commented Sep 11, 2022

Add a check for existing cluster-definition.json file. This will error out and leave the current file intact.

category: bug
ticket: #1062

@dB2510 dB2510 linked an issue Sep 11, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 11, 2022

Codecov Report

Merging #1111 (1e95104) into main (50e6b5c) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1111      +/-   ##
==========================================
+ Coverage   52.98%   53.01%   +0.03%     
==========================================
  Files         128      128              
  Lines       14482    14485       +3     
==========================================
+ Hits         7673     7679       +6     
+ Misses       5707     5704       -3     
  Partials     1102     1102              
Impacted Files Coverage Δ
cmd/createdkg.go 70.21% <100.00%> (+0.98%) ⬆️
app/app.go 59.48% <0.00%> (-1.78%) ⬇️
core/scheduler/scheduler.go 74.04% <0.00%> (+0.54%) ⬆️
core/dutydb/memory.go 70.89% <0.00%> (+1.11%) ⬆️
dkg/transport.go 66.66% <0.00%> (+12.96%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dB2510 dB2510 added the merge when ready Indicates bulldozer bot may merge when all checks pass label Sep 11, 2022
@obol-bulldozer obol-bulldozer bot merged commit 8b1993c into main Sep 11, 2022
@obol-bulldozer obol-bulldozer bot deleted the dhruv/createdkg branch September 11, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Charon create dkg overwrites the cluster-definition file
2 participants