Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Charon create dkg overwrites the cluster-definition file #1062

Closed
Battenfield opened this issue Aug 31, 2022 · 0 comments · Fixed by #1111
Closed

Charon create dkg overwrites the cluster-definition file #1062

Battenfield opened this issue Aug 31, 2022 · 0 comments · Fixed by #1111
Assignees
@dB2510
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Battenfield
Copy link

🐞 Bug Report

Description

charon create dkg overwrites the cluster-definition.json file. This should error out and leave the current file intact.

Has this worked before in a previous version?

Oisin mentioned that there was previous work to attempt to stop the overwrite. Unsure if it was ever working.

🔬 Minimal Reproduction

  • Drop in a cluster-definition.json` file
  • run charon create dkg
  • definition file has changed
@OisinKyne OisinKyne added bug Something isn't working good first issue Good for newcomers labels Sep 1, 2022
@dB2510 dB2510 self-assigned this Sep 8, 2022
@dB2510 dB2510 mentioned this issue Sep 11, 2022
Merged
@dB2510 dB2510 linked a pull request Sep 11, 2022 that will close this issue
cmd/createdkg: add existing cluster definition check #1111
Merged
obol-bulldozer bot pushed a commit that referenced this issue Sep 11, 2022
@dB2510
cmd/createdkg: add existing cluster definition check (#1111)
8b1993c 
Add a check for existing cluster-definition.json file. This will error out and leave the current file intact.

category: bug
ticket: #1062
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dB2510 dB2510

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmd/createdkg: add existing cluster definition check ObolNetwork/charon
3 participants
@OisinKyne @Battenfield @dB2510