app/peerinfo: implement protocol skeleton #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 53.20% // Head: 53.13% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1225 +/- ##
==========================================
- Coverage 53.20% 53.13% -0.07%
==========================================
Files 136 136
Lines 15958 15958
==========================================
- Hits 8490 8479 -11
- Misses 6227 6234 +7
- Partials 1241 1245 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dB2510
approved these changes
Oct 5, 2022
Comment on lines
+42
to
+45
| type ( | ||
| tickerProvider func() (<-chan time.Time, func()) | ||
| nowFunc func() time.Time | ||
| ) |
| tickerProvider, nowFunc) | ||
| } | ||
|
|
||
| func newInternal(tcpNode host.Host, peers []peer.ID, version string, lockHash []byte, |
There was a problem hiding this comment.
new internal what?
this function name seems vague
There was a problem hiding this comment.
New and NewForT both call newInternal since it is the new function used internally
corverroos
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the skeleton for the new
peerinfoprotocol. It is aimed at sharing peer information/metadata.The supported use-cases are:
Tests will be added in a separate PR.
category: feature
ticket: #1224