core/tracker: detect inconsistent partial signed data #1343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 53.59% // Head: 53.75% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1343 +/- ##
==========================================
+ Coverage 53.59% 53.75% +0.16%
==========================================
Files 143 142 -1
Lines 17034 17099 +65
==========================================
+ Hits 9129 9192 +63
+ Misses 6633 6632 -1
- Partials 1272 1275 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
xenowits
reviewed
Oct 25, 2022
| // expectInconsistentParSigs returns true if the duty type is expected to sometimes | ||
| // produce inconsistent partial signed data. | ||
| func expectInconsistentParSigs(duty core.DutyType) bool { | ||
| return duty == core.DutySyncMessage || duty == core.DutySyncContribution |
There was a problem hiding this comment.
shouldn't this be
Suggested change
| return duty == core.DutySyncMessage || duty == core.DutySyncContribution | |
| return duty == core.DutySyncMessage || duty == core.DutyPrepareSyncContribution |
??
There was a problem hiding this comment.
no, SyncCommitteeSelection should always be consistent, whlie ContributionAndProof contains the beaconblockroot that VC pick themselves.
xenowits
reviewed
Oct 25, 2022
xenowits
reviewed
Oct 25, 2022
core/tracker/tracker.go
Outdated
| @@ -287,15 +327,49 @@ func analyseDutyFailed(duty core.Duty, allEvents map[core.Duty][]event) (bool, c | |||
| return true, comp, msg | |||
| } | |||
|
|
|||
| // analyseParSigs returns a mapping partial signed data messages by peers (share index). | |||
| func analyseParSigs(duty core.Duty, allEvents map[core.Duty][]event) parsigsByMsg { | |||
There was a problem hiding this comment.
also curious as to why this function needs all the events and not just the events for the duty?
will this work?
Suggested change
| func analyseParSigs(duty core.Duty, allEvents map[core.Duty][]event) parsigsByMsg { | |
| func analyseParSigs(duty core.Duty, events []event) parsigsByMsg { |
There was a problem hiding this comment.
indeed, good catch
xenowits
approved these changes
Oct 25, 2022
Co-authored-by: Abhishek Kumar <43061995+xenowits@users.noreply.github.com>
corverroos
added
the
merge when ready
obol-bulldozer bot
pushed a commit
that referenced
this pull request
Oct 27, 2022
) Verify inner attestation aggregation selection proof, not just the aggregation signature. This should fix the sporadic aggregation failures which I suspect is due to the cluster running both validatormock and teku, and that teku is per-chance submitting aggregation using legacy selection proofs in the same slot. It is also good practice to verify all signatures. category: bug ticket: #1343
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Track inconsistent partial signature data in tracker.
category: feature
ticket: #1342