Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate attestation fails with inconsistent data #1347

Closed
corverroos opened this issue Oct 25, 2022 · 1 comment
Closed

Aggregate attestation fails with inconsistent data #1347

corverroos opened this issue Oct 25, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@corverroos
Copy link
Contributor

馃悶 Bug Report

Description

Seeing sporadic attestation aggregation failures in parsigdb due to insufficient partial signatures received, minimum required threshold not reached. But seeing the logs, threshold partial signatures were submitted. This is unexpected.

image

This PR should highlight the issue further #1343.

obol-bulldozer bot pushed a commit that referenced this issue Oct 25, 2022
Add explicit unsigned data message root function to signed data as a better way to ensure consistent unsigned data in parsigdb. Relying on json serialisation to check for consistent signed data is brittle.

category: refactor
ticket: #1347
obol-bulldozer bot pushed a commit that referenced this issue Oct 26, 2022
Use message root for partial signed data consistency check in parsigdb. Also do the same in tracker.

category: refactor
ticket: #1347
@corverroos corverroos changed the title Aggregate attestation fails with possible inconsistent data Aggregate attestation fails with inconsistent data Oct 26, 2022
@corverroos
Copy link
Contributor Author

The inconsistency is in selection proof.....
image

obol-bulldozer bot pushed a commit that referenced this issue Oct 26, 2022
Fixes a bug in the newly added logic in tracker that checks for consistent partial signed message roots. It didn't support multiple validators performing a duty in the same slot.

category: bug
ticket: #1347
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant