Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/tracker: fix inconsistent message logic #1356

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

corverroos
Copy link
Contributor

Fixes a bug in the newly added logic in tracker that checks for consistent partial signed message roots. It didn't support multiple validators performing a duty in the same slot.

category: bug
ticket: #1347

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Base: 53.27% // Head: 53.71% // Increases project coverage by +0.43% 🎉

Coverage data is based on head (699944e) compared to base (19dd5b7).
Patch coverage: 80.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1356      +/-   ##
==========================================
+ Coverage   53.27%   53.71%   +0.43%     
==========================================
  Files         142      142              
  Lines       17226    17247      +21     
==========================================
+ Hits         9178     9265      +87     
+ Misses       6760     6701      -59     
+ Partials     1288     1281       -7     
Impacted Files Coverage Δ
core/tracker/tracker.go 71.11% <80.00%> (+0.79%) ⬆️
dkg/transport.go 53.70% <0.00%> (-12.97%) ⬇️
core/scheduler/scheduler.go 73.77% <0.00%> (+0.49%) ⬆️
app/vmock.go 73.79% <0.00%> (+2.67%) ⬆️
app/app.go 65.45% <0.00%> (+4.50%) ⬆️
core/qbft/qbft.go 81.97% <0.00%> (+10.30%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label Oct 26, 2022
@obol-bulldozer obol-bulldozer bot merged commit 83e2130 into main Oct 26, 2022
@obol-bulldozer obol-bulldozer bot deleted the corver/fixinconsistency branch October 26, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants