Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/validatorapi: add support for DutySyncContribution #1363

Merged
merged 2 commits into from
Oct 31, 2022

Conversation

xenowits
Copy link
Contributor

Adds support for DutySyncContribution to validatorapi.

category: feature
ticket: #1267

@xenowits xenowits self-assigned this Oct 27, 2022
@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Base: 54.20% // Head: 53.67% // Decreases project coverage by -0.53% ⚠️

Coverage data is based on head (6afd22b) compared to base (d2c0053).
Patch coverage: 45.71% of modified lines in pull request are covered.

❗ Current head 6afd22b differs from pull request most recent head 4fe10c6. Consider uploading reports for the commit 4fe10c6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1363      +/-   ##
==========================================
- Coverage   54.20%   53.67%   -0.54%     
==========================================
  Files         144      142       -2     
  Lines       17516    17719     +203     
==========================================
+ Hits         9495     9511      +16     
- Misses       6722     6874     +152     
- Partials     1299     1334      +35     
Impacted Files Coverage Δ
core/signeddata.go 38.27% <0.00%> (-8.47%) ⬇️
core/validatorapi/eth2types.go 50.00% <ø> (ø)
core/validatorapi/router.go 62.13% <47.72%> (-0.46%) ⬇️
eth2util/signing/signing.go 41.53% <52.00%> (+7.15%) ⬆️
core/validatorapi/validatorapi.go 57.05% <54.54%> (-1.29%) ⬇️
core/parsigex/parsigex.go 58.99% <0.00%> (-3.65%) ⬇️
testutil/beaconmock/attestation.go 82.60% <0.00%> (-3.11%) ⬇️
core/priority/prioritiser.go 61.65% <0.00%> (-2.08%) ⬇️
core/qbft/qbft.go 80.47% <0.00%> (-1.51%) ⬇️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

core/validatorapi/router.go Outdated Show resolved Hide resolved
core/validatorapi/router.go Outdated Show resolved Hide resolved
core/validatorapi/router.go Outdated Show resolved Hide resolved
core/validatorapi/validatorapi.go Outdated Show resolved Hide resolved
core/validatorapi/validatorapi_test.go Show resolved Hide resolved
@xenowits xenowits force-pushed the xenowits/vapi-sync-contribution branch 2 times, most recently from 6afd22b to 96c7495 Compare October 28, 2022 15:47
@xenowits xenowits force-pushed the xenowits/vapi-sync-contribution branch from 96c7495 to 4fe10c6 Compare October 31, 2022 14:27
@xenowits xenowits added the merge when ready Indicates bulldozer bot may merge when all checks pass label Oct 31, 2022
@obol-bulldozer obol-bulldozer bot merged commit 8bf8ab0 into main Oct 31, 2022
@obol-bulldozer obol-bulldozer bot deleted the xenowits/vapi-sync-contribution branch October 31, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants