Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/dutydb: add support for DutySyncContribution #1364

Merged
merged 3 commits into from
Oct 28, 2022

Conversation

xenowits
Copy link
Contributor

Adds support for DutySyncContribution.

category: feature
ticket: #1270

@xenowits xenowits self-assigned this Oct 27, 2022
@xenowits xenowits marked this pull request as draft October 27, 2022 17:35
@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Base: 53.20% // Head: 53.58% // Increases project coverage by +0.37% 🎉

Coverage data is based on head (13fa161) compared to base (741c6d0).
Patch coverage: 79.31% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1364      +/-   ##
==========================================
+ Coverage   53.20%   53.58%   +0.37%     
==========================================
  Files         142      142              
  Lines       17400    17478      +78     
==========================================
+ Hits         9258     9365     +107     
+ Misses       6838     6803      -35     
- Partials     1304     1310       +6     
Impacted Files Coverage Δ
core/interfaces.go 0.00% <ø> (ø)
core/unsigneddata.go 46.97% <0.00%> (-0.45%) ⬇️
core/dutydb/memory.go 68.59% <81.17%> (+2.20%) ⬆️
dkg/transport.go 53.70% <0.00%> (-12.97%) ⬇️
app/vmock.go 73.79% <0.00%> (ø)
core/scheduler/scheduler.go 73.77% <0.00%> (+0.49%) ⬆️
core/leadercast/transport.go 76.33% <0.00%> (+1.18%) ⬆️
core/priority/prioritiser.go 63.73% <0.00%> (+2.07%) ⬆️
core/qbft/qbft.go 81.54% <0.00%> (+9.87%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@corverroos corverroos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xenowits xenowits marked this pull request as ready for review October 28, 2022 08:44
@xenowits xenowits added the merge when ready Indicates bulldozer bot may merge when all checks pass label Oct 28, 2022
@obol-bulldozer obol-bulldozer bot merged commit 5c3728b into main Oct 28, 2022
@obol-bulldozer obol-bulldozer bot deleted the xenowits/dutydb-contribution-duty branch October 28, 2022 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants