Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app: refactor prioritise to beta feature #1432

Merged
merged 1 commit into from
Nov 11, 2022
Merged

Conversation

corverroos
Copy link
Contributor

Move priority protocol to beta feature as it still has a goroutine leak and needs a big refactor.

category: misc
ticket: #1421

@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label Nov 11, 2022
@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Base: 53.33% // Head: 53.21% // Decreases project coverage by -0.12% ⚠️

Coverage data is based on head (21aa715) compared to base (514ae1d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1432      +/-   ##
==========================================
- Coverage   53.33%   53.21%   -0.13%     
==========================================
  Files         148      148              
  Lines       18390    18393       +3     
==========================================
- Hits         9809     9788      -21     
- Misses       7234     7255      +21     
- Partials     1347     1350       +3     
Impacted Files Coverage Δ
app/featureset/featureset.go 100.00% <ø> (ø)
app/app.go 60.47% <100.00%> (-1.17%) ⬇️
core/priority/prioritiser.go 61.62% <0.00%> (-2.72%) ⬇️
app/vmock.go 72.53% <0.00%> (-1.56%) ⬇️
core/scheduler/scheduler.go 72.66% <0.00%> (-1.20%) ⬇️
core/qbft/qbft.go 81.93% <0.00%> (-0.43%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@obol-bulldozer obol-bulldozer bot merged commit 5e96c9d into main Nov 11, 2022
@obol-bulldozer obol-bulldozer bot deleted the corver/betaprio branch November 11, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants