core/tracker: implement inclusion delay tracker #1468
Conversation
Codecov ReportBase: 54.01% // Head: 53.72% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1468 +/- ##
==========================================
- Coverage 54.01% 53.72% -0.30%
==========================================
Files 147 148 +1
Lines 18683 18751 +68
==========================================
- Hits 10092 10074 -18
- Misses 7217 7297 +80
- Partials 1374 1380 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
core/tracker/incldelay.go
Outdated
| "github.com/obolnetwork/charon/core" | ||
| ) | ||
|
|
||
| // epochLag is the number of epochs to lag when calculating inclusion delay (to ensure finality). |
There was a problem hiding this comment.
finality is ensured in atleast 2 epochs, why is the lag equal to 1 ?
There was a problem hiding this comment.
updated the comment accordingly
core/tracker/incldelay.go
Outdated
| } | ||
|
|
||
| blockSlot := current.Slot - (epochLag * current.SlotsPerEpoch) | ||
| if blockSlot < fromSlot { |
There was a problem hiding this comment.
add a comment for this condition
core/tracker/incldelay.go
Outdated
| // is expected by the network and the slot the attestation is actually included on-chain. | ||
| // See https://rated.gitbook.io/rated-documentation/rating-methodologies/ethereum-beacon-chain/network-explorer-definitions/top-screener#inclusion-delay. | ||
| func NewInclDelayFunc(eth2Cl eth2wrap.Client, dutiesFunc dutiesFunc) func(context.Context, core.Slot) error { | ||
| return newInclDelayFunc(eth2Cl, dutiesFunc, func(delays []int64) { |
There was a problem hiding this comment.
nit: this callback function can be written outside as a separate function for better readability
core/tracker/incldelay.go
Outdated
|
|
||
| // newInclDelayFunc extends NewInclDelayFunc with abstracted callback. | ||
| func newInclDelayFunc(eth2Cl eth2wrap.Client, dutiesFunc dutiesFunc, callback func([]int64)) func(context.Context, core.Slot) error { | ||
| var fromSlot int64 |
There was a problem hiding this comment.
suggest: add comment for this variable
Co-authored-by: Abhishek Kumar <43061995+xenowits@users.noreply.github.com>
corverroos
added
the
merge when ready
Implement a function that calculates the clusters inclusion delay for a specific block.
category: feature
ticket: #1254