Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: clear previous status when validator status changes #1489

Merged
merged 6 commits into from
Nov 30, 2022

Conversation

xenowits
Copy link
Contributor

Clears previous status when validator status changes. For ex: when a validator progresses from pending_queued to active_ongoing, we currently see two values, one for each status. This PR fixes this by removing the older statuses. In this example, it removes status pending_queued.

category: refactor
ticket: ObolNetwork/charon-distributed-validator-node#139

@xenowits xenowits self-assigned this Nov 29, 2022
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Base: 53.24% // Head: 53.27% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (eb51505) compared to base (1439367).
Patch coverage: 76.92% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1489      +/-   ##
==========================================
+ Coverage   53.24%   53.27%   +0.02%     
==========================================
  Files         149      149              
  Lines       18979    18988       +9     
==========================================
+ Hits        10106    10116      +10     
- Misses       7489     7492       +3     
+ Partials     1384     1380       -4     
Impacted Files Coverage Δ
core/scheduler/metrics.go 81.25% <72.72%> (-18.75%) ⬇️
core/scheduler/scheduler.go 72.66% <100.00%> (ø)
app/app.go 63.25% <0.00%> (-0.76%) ⬇️
core/qbft/qbft.go 71.81% <0.00%> (-0.63%) ⬇️
app/vmock.go 76.16% <0.00%> (+0.51%) ⬆️
core/dutydb/memory.go 69.28% <0.00%> (+0.69%) ⬆️
core/priority/prioritiser.go 65.43% <0.00%> (+2.88%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

core/scheduler/metrics.go Outdated Show resolved Hide resolved
@xenowits
Copy link
Contributor Author

Screenshot 2022-11-29 at 10 27 11 PM

@xenowits xenowits added the merge when ready Indicates bulldozer bot may merge when all checks pass label Nov 30, 2022
@obol-bulldozer obol-bulldozer bot merged commit 26f387b into main Nov 30, 2022
@obol-bulldozer obol-bulldozer bot deleted the xenowits/clear-validator-status branch November 30, 2022 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants