Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: add --definition-file flag to create cluster command #1558

Closed
wants to merge 1 commit into from

Conversation

xenowits
Copy link
Contributor

Refactors charon create cluster command to fetch partial (solo-flow) cluster definition and use it for creating cluster outputs.

category: feature
ticket: #1490

@xenowits xenowits self-assigned this Dec 14, 2022
@xenowits xenowits marked this pull request as draft December 14, 2022 13:56
@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Base: 54.14% // Head: 54.23% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (0894aec) compared to base (febb425).
Patch coverage: 35.29% of modified lines in pull request are covered.

❗ Current head 0894aec differs from pull request most recent head 08e9722. Consider uploading reports for the commit 08e9722 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1558      +/-   ##
==========================================
+ Coverage   54.14%   54.23%   +0.08%     
==========================================
  Files         157      154       -3     
  Lines       19711    19557     -154     
==========================================
- Hits        10673    10606      -67     
+ Misses       7590     7514      -76     
+ Partials     1448     1437      -11     
Impacted Files Coverage Δ
cluster/definition.go 60.14% <0.00%> (ø)
cluster/lock.go 58.10% <ø> (ø)
cluster/test_cluster.go 81.11% <3.57%> (-18.89%) ⬇️
cmd/createcluster.go 47.43% <47.14%> (+0.62%) ⬆️
dkg/disk.go 55.63% <50.00%> (ø)
cluster/helpers.go 59.64% <100.00%> (ø)
app/vmock.go 72.53% <0.00%> (-5.19%) ⬇️
app/monitoringapi.go 77.00% <0.00%> (-3.00%) ⬇️
p2p/bootnode.go 20.53% <0.00%> (-2.68%) ⬇️
app/peerinfo/peerinfo.go 51.26% <0.00%> (-1.27%) ⬇️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

cmd/createcluster_internal_test.go Outdated Show resolved Hide resolved
cmd/createcluster_internal_test.go Outdated Show resolved Hide resolved
cmd/createcluster.go Outdated Show resolved Hide resolved
cmd/createcluster.go Outdated Show resolved Hide resolved
cmd/createcluster.go Outdated Show resolved Hide resolved
@xenowits xenowits marked this pull request as ready for review December 15, 2022 13:41
cluster/test_cluster.go Outdated Show resolved Hide resolved
@xenowits
Copy link
Contributor Author

Closing this in favour of #1615

@xenowits xenowits closed this Jan 10, 2023
@corverroos corverroos deleted the xenowits/partial-def-flag branch February 3, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants