Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app/monitoring: re-enable detect VC feature #1597

Merged
merged 7 commits into from
Jan 6, 2023
Merged

Conversation

dB2510
Copy link
Contributor

@dB2510 dB2510 commented Jan 6, 2023

Configures monitoringapi to detect all validators queried by VC.
Note: This needs to be tested.

category: feature
ticket: #1501

@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Base: 54.14% // Head: 53.95% // Decreases project coverage by -0.19% ⚠️

Coverage data is based on head (8848e08) compared to base (d7760ca).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1597      +/-   ##
==========================================
- Coverage   54.14%   53.95%   -0.20%     
==========================================
  Files         157      157              
  Lines       19916    19925       +9     
==========================================
- Hits        10784    10751      -33     
- Misses       7678     7723      +45     
+ Partials     1454     1451       -3     
Impacted Files Coverage Δ
app/metrics.go 100.00% <ø> (ø)
app/monitoringapi.go 81.45% <100.00%> (+1.45%) ⬆️
core/qbft/qbft.go 73.73% <0.00%> (-10.09%) ⬇️
core/priority/prioritiser.go 58.87% <0.00%> (-3.23%) ⬇️
app/app.go 64.33% <0.00%> (+0.69%) ⬆️
app/vmock.go 74.09% <0.00%> (+1.55%) ⬆️
dkg/transport.go 66.66% <0.00%> (+12.96%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dB2510 dB2510 added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jan 6, 2023
@obol-bulldozer obol-bulldozer bot merged commit cf64b02 into main Jan 6, 2023
@obol-bulldozer obol-bulldozer bot deleted the dhruv/detectvc branch January 6, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants