Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: revert partial definition #1602

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Conversation

corverroos
Copy link
Contributor

@corverroos corverroos commented Jan 9, 2023

Removes partial definition concept. Supports "solo flow" cluster definition with signed creator and empty operators.

category: refactor
ticket: #1591

@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Base: 54.28% // Head: 54.36% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (719983b) compared to base (f796153).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1602      +/-   ##
==========================================
+ Coverage   54.28%   54.36%   +0.08%     
==========================================
  Files         157      157              
  Lines       19953    19909      -44     
==========================================
- Hits        10831    10824       -7     
+ Misses       7665     7643      -22     
+ Partials     1457     1442      -15     
Impacted Files Coverage Δ
cluster/definition.go 64.16% <0.00%> (+4.01%) ⬆️
app/peerinfo/peerinfo.go 51.57% <0.00%> (-3.15%) ⬇️
core/leadercast/transport.go 75.14% <0.00%> (-1.19%) ⬇️
app/vmock.go 74.61% <0.00%> (-1.04%) ⬇️
app/app.go 64.21% <0.00%> (+0.70%) ⬆️
core/priority/prioritiser.go 61.69% <0.00%> (+1.20%) ⬆️
core/qbft/qbft.go 83.82% <0.00%> (+1.47%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jan 9, 2023
@obol-bulldozer obol-bulldozer bot merged commit e49a552 into main Jan 9, 2023
@obol-bulldozer obol-bulldozer bot deleted the corver/removepartialdef branch January 9, 2023 10:56
xenowits pushed a commit that referenced this pull request Jan 9, 2023
Removes partial definition concept. Supports "solo flow" cluster definition with signed creator and empty operators. 

category: refactor
ticket: #1591
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants