p2p: relay discovery supports external ip and host #1604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 54.28% // Head: 54.31% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1604 +/- ##
==========================================
+ Coverage 54.28% 54.31% +0.02%
==========================================
Files 157 156 -1
Lines 19953 19961 +8
==========================================
+ Hits 10831 10841 +10
- Misses 7665 7677 +12
+ Partials 1457 1443 -14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
xenowits
reviewed
Jan 9, 2023
| } | ||
|
|
||
| var resp []ma.Multiaddr | ||
|
|
There was a problem hiding this comment.
added new line since we append to it in two different if blocks
xenowits
approved these changes
Jan 9, 2023
xenowits
reviewed
Jan 9, 2023
Co-authored-by: Abhishek Kumar <43061995+xenowits@users.noreply.github.com>
corverroos
added
the
merge when ready
Removes partial definition concept. Supports "solo flow" cluster definition with signed creator and empty operators. category: refactor ticket: #1591
Delete expired data in aggsigdb when duty expires. Also delete abandoned queries to avoid memory leaks. category: feature ticket: #1582
Fixes flapping [test](https://github.com/ObolNetwork/charon/actions/runs/3873088789/jobs/6602699504) due to race condition between context cancel and storing data. category: test ticket: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for external IP and external hostname to relay discovery.
category: feature
ticket: #1590