featureset: herumi_bls feature flag
#1745
Conversation
…ependencies Needed because sometimes the environment in which we execute the binary (Docker, Debian) might run a different version of glibc than host, leading to runtime errors.
Codecov ReportBase: 54.76% // Head: 54.54% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1745 +/- ##
==========================================
- Coverage 54.76% 54.54% -0.23%
==========================================
Files 162 162
Lines 20820 20831 +11
==========================================
- Hits 11402 11362 -40
- Misses 7894 7944 +50
- Partials 1524 1525 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
app/app.go
Outdated
| blsv2.SetImplementation(kryptology.Kryptology{}) | ||
|
|
||
| if featureset.Enabled(featureset.HerumiBLS) { | ||
| log.Info(ctx, "enabling Herumi BLS signature backend") |
There was a problem hiding this comment.
log lines should start with a capital
There was a problem hiding this comment.
this should've been covered in pre-commit hooks. @gsora do you have pre-commit installed on your local?
There was a problem hiding this comment.
There was a problem hiding this comment.
I did! That's how I fix the pre-commit issues that appear in CI. For some reason it isn't executing at commit time... I re-tried installation, hopefully this stuff will get caught from now on.
Sorry!
gsora
added
the
merge when ready
This PR adds support for the
herumi_blsfeature flag.Right now the flag is used in
app/app.goin preparation for #1744, but apart for that this is 100% dormant code.I had to update the way we compile binaries for
composeso that we don't end up with glibc issues between host and Docker.category: feature
ticket: #1743