core/dutydb: refactor aggregation bits #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corverroos
changed the title
Codecov Report
@@ Coverage Diff @@
## main #182 +/- ##
=======================================
Coverage ? 54.44%
=======================================
Files ? 39
Lines ? 2439
Branches ? 0
=======================================
Hits ? 1328
Misses ? 977
Partials ? 134 Continue to review full report at Codecov.
|
dB2510
approved these changes
Mar 5, 2022
corverroos
commented
Mar 5, 2022
Comment on lines
-24
to
-48
| // getAggBitsHex returns the aggregation bits hex for a committee | ||
| // with length validators and the validator as index set to true. | ||
| func getAggBitsHex(length, index uint64) (string, error) { | ||
| if length == 0 { | ||
| return "0x00", nil | ||
| } | ||
|
|
||
| if length <= index { | ||
| return "", errors.New("agg bit index not smaller than length", | ||
| z.U64("length", length), z.U64("index", index)) | ||
| } | ||
|
|
||
| extra := uint64(1) | ||
| if length%8 == 0 { | ||
| extra = 0 | ||
| } | ||
|
|
||
| buckets := length/8 + extra | ||
| bitList := make([]byte, buckets) | ||
|
|
||
| offset := buckets - 1 - index/8 | ||
| bitList[offset] = byte(0x01 << (index % 8)) | ||
|
|
||
| return "0x" + hex.EncodeToString(bitList), nil | ||
| } |
There was a problem hiding this comment.
this is how the VC calculates the value of aggbits it includes in the attestation
it gets the inputs values from AttestationDuty
aggbits := getAggBitsHex(duty.CommitteeLength, duty.ValidatorCommitteeIndex)
Co-authored-by: Dhruv Bodani <dhruvbodani2510@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the pubkey lookup when an attestation is submitted. Instead of using aggregation bits, use the validator committee index explicitly.
category: refactor
ticket: #165