Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: fix data race in scheduler #1866

Merged
merged 4 commits into from
Mar 9, 2023
Merged

Conversation

xenowits
Copy link
Contributor

@xenowits xenowits commented Mar 9, 2023

Fixes data race in scheduler.go.

category: fixbuild
ticket: none

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: +0.04 🎉

Comparison is base (02338c7) 55.33% compared to head (3617536) 55.37%.

❗ Current head 3617536 differs from pull request most recent head 6148089. Consider uploading reports for the commit 6148089 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1866      +/-   ##
==========================================
+ Coverage   55.33%   55.37%   +0.04%     
==========================================
  Files         169      169              
  Lines       21825    21825              
==========================================
+ Hits        12076    12085       +9     
+ Misses       8193     8187       -6     
+ Partials     1556     1553       -3     
Impacted Files Coverage Δ
core/scheduler/scheduler.go 77.34% <50.00%> (ø)
core/leadercast/transport.go 75.14% <0.00%> (-1.19%) ⬇️
core/qbft/qbft.go 82.98% <0.00%> (-0.85%) ⬇️
app/app.go 64.18% <0.00%> (+0.33%) ⬆️
core/priority/prioritiser.go 61.79% <0.00%> (+1.41%) ⬆️
app/vmock.go 77.94% <0.00%> (+5.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@xenowits xenowits self-assigned this Mar 9, 2023
@xenowits xenowits added the merge when ready Indicates bulldozer bot may merge when all checks pass label Mar 9, 2023
@obol-bulldozer obol-bulldozer bot merged commit f2660f4 into main Mar 9, 2023
@obol-bulldozer obol-bulldozer bot deleted the xenowits/fix-date-race branch March 9, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants