tbls: temporarily swap to kryptology fork #188
Conversation
Codecov Report
@@ Coverage Diff @@
## main #188 +/- ##
=======================================
Coverage ? 52.34%
=======================================
Files ? 43
Lines ? 2707
Branches ? 0
=======================================
Hits ? 1417
Misses ? 1137
Partials ? 153 Continue to review full report at Codecov.
|
| if err != nil || !ok { | ||
| continue | ||
| } | ||
| validShares = append(validShares, pubShare) | ||
|
|
||
| validSigs = append(validSigs, psig) | ||
| signers = append(signers, psig.Identifier) |
There was a problem hiding this comment.
We don't need this line since we are storing validSigs which has Identifier in it
There was a problem hiding this comment.
yeah, but then you need to extract valid sig identifiers later, so might as well do it here.
| @@ -162,6 +172,16 @@ func PartialSign(sks *bls_sig.SecretKeyShare, msg []byte) (*bls_sig.PartialSigna | |||
| return psig, nil | |||
| } | |||
|
|
|||
| // Sign signs given message(msg) using given Secret Key(sk) and returns a Signature. | |||
| func Sign(sk *bls_sig.SecretKey, msg []byte) (*bls_sig.Signature, error) { | |||
There was a problem hiding this comment.
why do we need this function? since kryptology has this function, we can directly use that
There was a problem hiding this comment.
Yeah it does, but this automatically selects the correct scheme.
Swaps kryptology for a fork that contains fixes for arm64.
category: refactor
ticket: #168