Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up on kryptology issues #168

Closed
corverroos opened this issue Mar 2, 2022 · 6 comments
Closed

Follow up on kryptology issues #168

corverroos opened this issue Mar 2, 2022 · 6 comments
Assignees
@Arash-Afshar
Labels
bug Something isn't working

Comments

@corverroos
Copy link
Contributor

Problem to solve

We discovered two issues with the kryptology library and opened issues and a PR, but this is still unresolved.

Proposed solution

  • Migrate to @dB2510 PR branch in the mean time to resolve the issues.
  • Push the guys from kryptology to address the issues.
@corverroos corverroos added the bug Something isn't working label Mar 2, 2022
@collinjmyers
Copy link

Maybe @Arash-Afshar can help with unblocking this for us?

@Arash-Afshar
Copy link

Arash-Afshar commented Mar 4, 2022 •
edited
Loading

@collinjmyers we are working on a fix. It should be ready in at most two weeks. Part of the delay is that we need our curve implementations to be constant time.

@corverroos
Copy link
Contributor Author

That is great news thanks @Arash-Afshar

@corverroos corverroos mentioned this issue Mar 7, 2022
Merged
corverroos added a commit that referenced this issue Mar 8, 2022
@corverroos
tbls: temporarily swap to kryptology fork (#188)
f0b92fb 
Swaps kryptology for a fork that contains fixes for arm64.

category: refactor
ticket: #168
@dB2510 dB2510 mentioned this issue Mar 12, 2022
Closed
@dB2510
Copy link
Contributor

dB2510 commented Mar 12, 2022

Hi @Arash-Afshar while updating our codebase to the latest release that is v1.8.0 I have found one issue: coinbase/kryptology#51

@dB2510
Copy link
Contributor

dB2510 commented Mar 12, 2022 •
edited
Loading

I have raised a PR(coinbase/kryptology#52) for a possible fix.

@dB2510
Copy link
Contributor

dB2510 commented Mar 19, 2022

We can close this issue.
Ref: #212

@dB2510 dB2510 closed this as completed Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arash-Afshar Arash-Afshar

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Arash-Afshar @corverroos @dB2510 @collinjmyers