-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app: wire and test simnet core workflow #206
Conversation
Codecov Report
@@ Coverage Diff @@
## main #206 +/- ##
=======================================
Coverage ? 51.32%
=======================================
Files ? 48
Lines ? 3236
Branches ? 0
=======================================
Hits ? 1661
Misses ? 1369
Partials ? 206 Continue to review full report at Codecov.
|
133d766
to
5f22e9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
tbls/tss.go
Outdated
// where Verifiers(coefficients of public polynomial) are used to compute sum of products of public polynomial with | ||
// identifier as x coordinate. | ||
// TODO(corver): Remove this once kryptology concurrency issues have been addressed. | ||
var mu sync.Mutex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can be defined above blsScheme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@@ -116,9 +117,15 @@ func Attest(ctx context.Context, eth2Cl Eth2AttProvider, signFunc SignFunc, | |||
return eth2Cl.SubmitAttestations(ctx, atts) | |||
} | |||
|
|||
// TODO(corver): Remove this once kryptology concurrency issues have been addressed. | |||
var mu sync.Mutex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
similarly here too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@@ -116,9 +117,15 @@ func Attest(ctx context.Context, eth2Cl Eth2AttProvider, signFunc SignFunc, | |||
return eth2Cl.SubmitAttestations(ctx, atts) | |||
} | |||
|
|||
// TODO(corver): Remove this once kryptology concurrency issues have been addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kryptology concurrency issues are resolved but still there's one small issue that is blocking our migration to coinbase/kryptology
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, can remove when reverted to kryptology
Wires the simnet core workflow using beaconmock and validaormock as well as a test that 2 slots are attested.
category: feature
ticket: #203