Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app: wire and test simnet core workflow #206

Merged
merged 4 commits into from
Mar 14, 2022
Merged

app: wire and test simnet core workflow #206

merged 4 commits into from
Mar 14, 2022

Conversation

corverroos
Copy link
Contributor

Wires the simnet core workflow using beaconmock and validaormock as well as a test that 2 slots are attested.

category: feature
ticket: #203

@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@dd1f8b2). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 1fb5d33 differs from pull request most recent head b4cd48b. Consider uploading reports for the commit b4cd48b to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #206   +/-   ##
=======================================
  Coverage        ?   51.32%           
=======================================
  Files           ?       48           
  Lines           ?     3236           
  Branches        ?        0           
=======================================
  Hits            ?     1661           
  Misses          ?     1369           
  Partials        ?      206           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd1f8b2...b4cd48b. Read the comment docs.

Base automatically changed from corver/prepsimnet to main March 10, 2022 11:42
Copy link
Contributor

@dB2510 dB2510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

tbls/tss.go Outdated
// where Verifiers(coefficients of public polynomial) are used to compute sum of products of public polynomial with
// identifier as x coordinate.
// TODO(corver): Remove this once kryptology concurrency issues have been addressed.
var mu sync.Mutex
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be defined above blsScheme

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -116,9 +117,15 @@ func Attest(ctx context.Context, eth2Cl Eth2AttProvider, signFunc SignFunc,
return eth2Cl.SubmitAttestations(ctx, atts)
}

// TODO(corver): Remove this once kryptology concurrency issues have been addressed.
var mu sync.Mutex
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similarly here too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -116,9 +117,15 @@ func Attest(ctx context.Context, eth2Cl Eth2AttProvider, signFunc SignFunc,
return eth2Cl.SubmitAttestations(ctx, atts)
}

// TODO(corver): Remove this once kryptology concurrency issues have been addressed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kryptology concurrency issues are resolved but still there's one small issue that is blocking our migration to coinbase/kryptology

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, can remove when reverted to kryptology

@corverroos corverroos merged commit 9d35a98 into main Mar 14, 2022
@corverroos corverroos deleted the corver/simnettest branch March 14, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants