Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dkg: add nil checks #2088

Merged
merged 3 commits into from
Apr 12, 2023
Merged

dkg: add nil checks #2088

merged 3 commits into from
Apr 12, 2023

Conversation

dB2510
Copy link
Contributor

@dB2510 dB2510 commented Apr 11, 2023

Adds nil pointer checks for relevant functions in dkg package.

Refer: OBOL-03

category: misc
ticket: #1997

@dB2510 dB2510 added the sigp audit Issues identified by sigma prime audit label Apr 11, 2023
dkg/frostp2p.go Outdated Show resolved Hide resolved
dkg/frostp2p.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Patch coverage: 31.42% and project coverage change: -0.18 ⚠️

Comparison is base (101453c) 53.57% compared to head (334a600) 53.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2088      +/-   ##
==========================================
- Coverage   53.57%   53.39%   -0.18%     
==========================================
  Files         174      174              
  Lines       22625    22697      +72     
==========================================
- Hits        12121    12120       -1     
- Misses       9000     9061      +61     
- Partials     1504     1516      +12     
Impacted Files Coverage Δ
dkg/frostp2p.go 63.46% <31.42%> (-5.07%) ⬇️

... and 12 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dB2510 dB2510 added the merge when ready Indicates bulldozer bot may merge when all checks pass label Apr 12, 2023
@obol-bulldozer obol-bulldozer bot merged commit ed5d746 into main Apr 12, 2023
@obol-bulldozer obol-bulldozer bot deleted the dhruv/dkgnilcheck branch April 12, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass sigp audit Issues identified by sigma prime audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants