Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nil Pointer References from Protobuf Messages. #1997

Closed
Tracked by #1991
dB2510 opened this issue Apr 3, 2023 · 0 comments · Fixed by #2090
Closed
Tracked by #1991

nil Pointer References from Protobuf Messages. #1997

dB2510 opened this issue Apr 3, 2023 · 0 comments · Fixed by #2090
Assignees
@dB2510
Labels
protocol Protocol Team tickets sigp audit Issues identified by sigma prime audit

Comments

@dB2510
Copy link
Contributor

dB2510 commented Apr 3, 2023 •
edited
Loading

Problem to be solved

Protobuf allows decoding pointer objects to nil . A nil pointer reference occurs when a program attempts to access
or dereference a pointer that has not been initialised, resulting in a runtime panic.

Proposed Solution

Check page 10 and 11 of sigma prime audit report.
@dB2510 dB2510 mentioned this issue Apr 3, 2023
Closed
1 task
@github-actions github-actions bot added the protocol Protocol Team tickets label Apr 3, 2023
@dB2510 dB2510 added the sigp audit Issues identified by sigma prime audit label Apr 3, 2023
@dB2510 dB2510 self-assigned this Apr 3, 2023
@dB2510 dB2510 mentioned this issue Apr 11, 2023
Merged
obol-bulldozer bot pushed a commit that referenced this issue Apr 12, 2023
@dB2510
dkg: add nil checks (#2088)
ed5d746 
Adds nil pointer checks for relevant functions in dkg package.

Refer: OBOL-03

category: misc
ticket: #1997
@dB2510 dB2510 mentioned this issue Apr 12, 2023
Merged
@dB2510 dB2510 linked a pull request Apr 12, 2023 that will close this issue
core: add nil checks #2090
Merged
obol-bulldozer bot pushed a commit that referenced this issue Apr 12, 2023
@dB2510
core: add nil checks (#2090)
f0f663e 
Adds nil checks before reading proto messages in core package mentioned in audit report.

Refer: OBOL-03

category: misc
ticket: #1997
@dB2510 dB2510 mentioned this issue Jun 20, 2023
Merged
obol-bulldozer bot pushed a commit that referenced this issue Jun 20, 2023
@dB2510
core: add remaining nil checks (#2338)
d9ce91e 
Add remaining nil checks that were missing as part of OBOL-03.

category: misc
ticket: #1997
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dB2510 dB2510

Labels
protocol Protocol Team tickets sigp audit Issues identified by sigma prime audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

core: add nil checks ObolNetwork/charon
1 participant
@dB2510