eth2util/signing: add constant genesis domain test #2174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2174 +/- ##
==========================================
+ Coverage 53.45% 53.54% +0.09%
==========================================
Files 174 174
Lines 22987 23085 +98
==========================================
+ Hits 12287 12361 +74
- Misses 9232 9250 +18
- Partials 1468 1474 +6
☔ View full report in Codecov by Sentry. |
dB2510
approved these changes
May 10, 2023
xenowits
reviewed
May 11, 2023
| } | ||
|
|
||
| // Assert genesis domain is used for any fork schedule. | ||
| expect := eth2p0.Domain{ |
There was a problem hiding this comment.
how did we get this domain value?
There was a problem hiding this comment.
I just ran the test, the point is not the value itself, but that is doesn't change
corverroos
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple unit test demonstrating that DomainApplicationBuilder uses genesis fork version domain.
category: test
ticket: none