Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: add remaining nil checks #2338

Merged
merged 2 commits into from
Jun 20, 2023
Merged

Conversation

dB2510
Copy link
Contributor

@dB2510 dB2510 commented Jun 20, 2023

Add remaining nil checks that were missing as part of OBOL-03.

category: misc
ticket: #1997

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.08 🎉

Comparison is base (db040d5) 53.56% compared to head (09625ef) 53.65%.

❗ Current head 09625ef differs from pull request most recent head 96fd018. Consider uploading reports for the commit 96fd018 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2338      +/-   ##
==========================================
+ Coverage   53.56%   53.65%   +0.08%     
==========================================
  Files         191      191              
  Lines       25730    25735       +5     
==========================================
+ Hits        13783    13808      +25     
+ Misses      10238    10219      -19     
+ Partials     1709     1708       -1     
Impacted Files Coverage Δ
core/consensus/msg.go 73.33% <0.00%> (-0.40%) ⬇️
core/priority/prioritiser.go 62.32% <0.00%> (+1.94%) ⬆️

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

core/consensus/msg.go Outdated Show resolved Hide resolved
core/priority/prioritiser.go Outdated Show resolved Hide resolved
@dB2510 dB2510 added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jun 20, 2023
@obol-bulldozer obol-bulldozer bot merged commit d9ce91e into main Jun 20, 2023
10 checks passed
@obol-bulldozer obol-bulldozer bot deleted the dhruv/remainingnilchecks branch June 20, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants