core/validatorapi: add validators to router #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #259 +/- ##
==========================================
+ Coverage 55.78% 55.91% +0.12%
==========================================
Files 53 53
Lines 3671 3781 +110
==========================================
+ Hits 2048 2114 +66
- Misses 1345 1374 +29
- Partials 278 293 +15
Continue to review full report at Codecov.
|
dB2510
approved these changes
Mar 21, 2022
core/validatorapi/router.go
Outdated
| @@ -337,6 +427,36 @@ | |||
| // uintParam returns a uint path parameter. | |||
| func uintParam(params map[string]string, name string) (uint64, error) { | |||
| param := params[name] | |||
| if param == "" { | |||
There was a problem hiding this comment.
can use comma ok idiom here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
/eth/v1/beacon/states/{state_id}/validatorsendpoint to validatorapi router.Also fixes:
dependent_root.category: feature
ticket: #251