Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: add custom testnet flags #2715

Merged
merged 16 commits into from
Nov 30, 2023
Merged

cmd: add custom testnet flags #2715

merged 16 commits into from
Nov 30, 2023

Conversation

dB2510
Copy link
Contributor

@dB2510 dB2510 commented Nov 17, 2023

Adds custom testnet flags to charon create cluster and charon run commands.

category: feature
ticket: #2690

@dB2510 dB2510 marked this pull request as draft November 17, 2023 12:14
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (4fa4f30) 53.36% compared to head (bb998da) 53.29%.
Report is 5 commits behind head on main.

Files Patch % Lines
cmd/createcluster.go 60.97% 12 Missing and 4 partials ⚠️
eth2util/network.go 68.08% 15 Missing ⚠️
app/app.go 0.00% 3 Missing ⚠️
app/monitoringapi.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2715      +/-   ##
==========================================
- Coverage   53.36%   53.29%   -0.07%     
==========================================
  Files         199      199              
  Lines       27397    27489      +92     
==========================================
+ Hits        14621    14651      +30     
- Misses      10969    11025      +56     
- Partials     1807     1813       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dB2510 dB2510 marked this pull request as ready for review November 29, 2023 10:37
@dB2510 dB2510 requested review from xenowits and gsora and removed request for xenowits November 29, 2023 11:42
@dB2510 dB2510 changed the title cmd: add custom testnet flags to create cluster cmd: add custom testnet flags Nov 29, 2023
app/app.go Outdated Show resolved Hide resolved
cmd/createcluster.go Outdated Show resolved Hide resolved
dB2510 and others added 2 commits November 29, 2023 17:23
Co-authored-by: Abhishek Kumar <43061995+xenowits@users.noreply.github.com>
eth2util/network.go Outdated Show resolved Hide resolved
cmd/createcluster.go Outdated Show resolved Hide resolved
eth2util/network.go Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Nov 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dB2510 dB2510 requested a review from gsora November 30, 2023 10:27
@dB2510 dB2510 self-assigned this Nov 30, 2023
@dB2510 dB2510 linked an issue Nov 30, 2023 that may be closed by this pull request
3 tasks
@dB2510 dB2510 added the merge when ready Indicates bulldozer bot may merge when all checks pass label Nov 30, 2023
@obol-bulldozer obol-bulldozer bot merged commit cb4c265 into main Nov 30, 2023
15 checks passed
@obol-bulldozer obol-bulldozer bot deleted the dhruv/testcreate branch November 30, 2023 11:05
xenowits pushed a commit that referenced this pull request Dec 12, 2023
Adds custom testnet flags to `charon create cluster` and `charon run` commands.

category: feature
ticket: #2690
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --testnet-* flags to support custom test networks.
3 participants