Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --testnet-* flags to support custom test networks. #2690

Closed
3 tasks
dB2510 opened this issue Nov 8, 2023 · 0 comments · Fixed by #2715
Closed
3 tasks

Add --testnet-* flags to support custom test networks. #2690

dB2510 opened this issue Nov 8, 2023 · 0 comments · Fixed by #2715
Assignees
@dB2510
Labels
protocol Protocol Team tickets

Comments

@dB2510
Copy link
Contributor

dB2510 commented Nov 8, 2023 •
edited
Loading

🎯 Problem to be solved

Currently we only support the cluster creation for public networks like mainnet, goerli, sepolia, holesky, etc. In order to test charon in a custom testnet with dynamic chain configuration, we need to add support for cluster creation for custom testnets.

🛠️ Proposed solution

Add a --testnet prefixed flags to charon create cluster and charon run to support custom networks. The expected flags should look like the following:

--testnet-chain-id uint             Chain ID of the custom test network.
--testnet-fork-version string       Genesis fork version of the custom test network (in hex).
--testnet-genesis-timestamp int     Genesis timestamp of the custom test network.
--testnet-name string               Name of the custom test network.

🧪 Tests

  • Tested by new automated unit/integration/smoke tests
  • Manually tested on core team/canary/test clusters
  • Manually tested on local compose simnet

-->
@github-actions github-actions bot added the protocol Protocol Team tickets label Nov 8, 2023
@dB2510 dB2510 mentioned this issue Nov 17, 2023
Merged
@dB2510 dB2510 self-assigned this Nov 21, 2023
@dB2510 dB2510 linked a pull request Nov 30, 2023 that will close this issue
cmd: add custom testnet flags #2715
Merged
obol-bulldozer bot pushed a commit that referenced this issue Nov 30, 2023
@dB2510
cmd: add custom testnet flags (#2715)
cb4c265 
Adds custom testnet flags to `charon create cluster` and `charon run` commands.

category: feature
ticket: #2690
@dB2510 dB2510 changed the title Add --testnet-file flag to support custom test networks. Add --testnet-* flags to support custom test networks. Nov 30, 2023
xenowits pushed a commit that referenced this issue Dec 12, 2023
@dB2510 @xenowits
cmd: add custom testnet flags (#2715)
7b8def6 
Adds custom testnet flags to `charon create cluster` and `charon run` commands.

category: feature
ticket: #2690
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dB2510 dB2510

Labels
protocol Protocol Team tickets
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmd: add custom testnet flags ObolNetwork/charon
1 participant
@dB2510