Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: add QEMU for arm64 builds #2980

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Conversation

KaloyanTanev
Copy link
Contributor

Some packages installed from the Dockerfile failed after #2971 was merged. Reason was it used default pre-installed version of qemu - the emulator used from amd64 architecture to build the arm64 images. Qemu is suggested by Dockerhub as well.

Dockerhub
Github Issue

category: fixbuild
ticket: none

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.19%. Comparing base (d076076) to head (cc673df).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2980      +/-   ##
==========================================
+ Coverage   54.18%   54.19%   +0.01%     
==========================================
  Files         195      195              
  Lines       27564    27564              
==========================================
+ Hits        14935    14938       +3     
+ Misses      10871    10866       -5     
- Partials     1758     1760       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pinebit pinebit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks safe and CI has passed all checks. Approved.

…64 builds

Signed-off-by: Kaloyan Tanev <kalo@obol.tech>
Copy link

sonarcloud bot commented Mar 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@KaloyanTanev
Copy link
Contributor Author

Force pushed, as I rotated my signing keys in github and apparently github assumes the signature from the previously used key as "unverified".

@KaloyanTanev KaloyanTanev added the merge when ready Indicates bulldozer bot may merge when all checks pass label Mar 22, 2024
@obol-bulldozer obol-bulldozer bot merged commit aa8a82e into main Mar 22, 2024
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the kalo/fix-qemu-in-pipeline branch March 22, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants