Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testutil: add extension to golden files #358

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Conversation

corverroos
Copy link
Contributor

Refactor golden test utilities to add golden extension.

category: refactor
ticket: #353

@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #358 (c468504) into main (5e40fca) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #358   +/-   ##
=======================================
  Coverage   54.10%   54.10%           
=======================================
  Files          63       63           
  Lines        5487     5487           
=======================================
  Hits         2969     2969           
  Misses       2117     2117           
  Partials      401      401           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e40fca...c468504. Read the comment docs.

Copy link
Contributor

@dB2510 dB2510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@obol-bulldozer obol-bulldozer bot merged commit 85dfd4a into main Apr 5, 2022
@obol-bulldozer obol-bulldozer bot deleted the corver/goldenext branch April 5, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants