Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .golden extension to golden test files #353

Closed
corverroos opened this issue Apr 5, 2022 · 0 comments
Closed

Add .golden extension to golden test files #353

corverroos opened this issue Apr 5, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@corverroos
Copy link
Contributor

Problem to be solved

Current golden test files do not have an extension. The concept of golden files could be formalised more clearly if they have a .golden extension.

Proposed solution

Update testutil to add a .golden extension to all generated golden files.
Regenerate all golden files.
@corverroos corverroos added the enhancement New feature or request label Apr 5, 2022
This was referenced Apr 5, 2022
Merged
Merged
obol-bulldozer bot pushed a commit that referenced this issue Apr 5, 2022
@corverroos
testutil: add extension to golden files (#358)
85dfd4a 
Refactor golden test utilities to add golden extension.

category: refactor
ticket: #353
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@corverroos