app: refactor tests to use bootnode command #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leolara
reviewed
Apr 12, 2022
| t.Cleanup(listener.Close) | ||
| errChan := make(chan error, 1) | ||
| go func() { | ||
| errChan <- cmd.RunBootnode(ctx, cmd.BootnodeConfig{ |
There was a problem hiding this comment.
@corverroos if the channel has capacity one, the write will not block, why then, put it in a different goroutine?
There was a problem hiding this comment.
Writing to the channel will not block, but the command itself blocks. cmd.RunBootnode is a long running command, it only stops at the end of the test when the context is closed.
leolara
approved these changes
Apr 12, 2022
corverroos
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the
app_testpackage to use the real bootnode command (instead of local test package bootnode). This is in preparation for adding circuit relay to charon and bootnodes.category: test
ticket: #413