cmd: add create dkg command #484
Conversation
Codecov Report
@@ Coverage Diff @@
## main #484 +/- ##
==========================================
- Coverage 56.29% 55.82% -0.48%
==========================================
Files 82 84 +2
Lines 7446 7504 +58
==========================================
- Hits 4192 4189 -3
- Misses 2678 2737 +59
- Partials 576 578 +2
Continue to review full report at Codecov.
|
| @@ -48,6 +48,9 @@ func New() *cobra.Command { | |||
| newBootnodeCmd(RunBootnode), | |||
| newCreateClusterCmd(runCreateCluster), | |||
| newDKGCmd(dkg.Run), | |||
| newCreateCmd( | |||
| newCreateDKGCmd(runCreateDKG), | |||
There was a problem hiding this comment.
charon create dkg just doesn't feel right to me
There was a problem hiding this comment.
i mean you can do a dkg (distributed key gen) but creating a dkg doesn't make sense to me
There was a problem hiding this comment.
I pushed for:
charon define dkg->cluster_definition.jsoncharon seal->cluster_lock.jsoncharon run
Or for local cluster flow:
charon define localcharon sealcharon run
But this this was rejected for:
charon create dkg->cluster_definition.jsoncharon dkg->cluster_lock.jsoncharon run
There was a problem hiding this comment.
is building a cluster_definition even part of a dkg?
There was a problem hiding this comment.
it's an input to a dkg, if i'm not wrong
There was a problem hiding this comment.
or we can do something like:
charon create dkg-cluster
or
charon create dkg-config
There was a problem hiding this comment.
Perhaps this should have been discussed as part of the ticket grooming. I don't think we should stop the merge of this because we do not agree on the command name. Let's create an issue and discuss it there the definete command name
corverroos
force-pushed
the
corver/frostwire
branch
from
09da975
to
eb45a38
Compare
corverroos
force-pushed
the
corver/createdkg
branch
from
9f5c7b9
to
f733eaf
Compare
corverroos
added
the
merge when ready
Adds the
charon create dkgcommand that generates a cluster definition file.category: feature
ticket: #442