Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to use a create command with subcommands #442

Closed
OisinKyne opened this issue Apr 25, 2022 · 2 comments · Fixed by #487
Closed

Refactor to use a create command with subcommands #442

OisinKyne opened this issue Apr 25, 2022 · 2 comments · Fixed by #487
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@OisinKyne
Copy link
Contributor

Problem to be solved

To clean up the charon [command] output, we want to nest a number of subcommands under charon create.

Proposed solution

Add the following commands under charon create

  • enr: Create an Ethereum Node Record private key to identify charon
  • dkg: Create a charon DKG configuration file for charon dkg
  • cluster: Create the configuration and private keys for a local cluster

Out of Scope

The functions don't need to work for this ticket. They should just exist, have appropriate flags, perform appropriate validation, and error with meaningful errors.

@OisinKyne OisinKyne added the enhancement New feature or request label Apr 25, 2022
@dB2510 dB2510 self-assigned this May 4, 2022
@OisinKyne
Copy link
Contributor Author

Let me know if you want to jam on the feature flags for these commands if you want to take an opportunity to simplify them @dB2510

@dB2510
Copy link
Contributor

dB2510 commented May 4, 2022

@OisinKyne sure let's get on a call to discuss

obol-bulldozer bot pushed a commit that referenced this issue May 5, 2022
Adds the `charon create dkg` command that generates a cluster definition file.

category: feature
ticket: #442
@dB2510 dB2510 linked a pull request May 5, 2022 that will close this issue
obol-bulldozer bot pushed a commit that referenced this issue May 5, 2022
Refactor `genp2pkey` and `create-cluster` commands to `create enr` and `create cluster` commands, i.e, subcommands of create command.

category: refactor
ticket: #442 
feature_set: stable
obol-bulldozer bot pushed a commit that referenced this issue May 6, 2022
Updates structure.md to add new commands

category: docs
ticket: #442
feature_set: stable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants