-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd: refactor to use create command #487
Conversation
Codecov Report
@@ Coverage Diff @@
## main #487 +/- ##
==========================================
+ Coverage 55.85% 55.95% +0.10%
==========================================
Files 84 84
Lines 7504 7502 -2
==========================================
+ Hits 4191 4198 +7
+ Misses 2737 2726 -11
- Partials 576 578 +2
Continue to review full report at Codecov.
|
@@ -43,13 +43,13 @@ func New() *cobra.Command { | |||
return newRootCmd( | |||
newVersionCmd(runVersionCmd), | |||
newEnrCmd(runNewENR), | |||
newGenP2PKeyCmd(runGenP2PKey), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rather retain the old ones, until we have fixed charon-docker-compose and the docs to use the new ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hey @dB2510, I'm making suggestions on text not just in this PR, but you might still fix them for me if you wouldn't mind 👼 I've marked with ** and ~~ for add and strike the changes I want to make.
And on the create command:
|
Refactor
genp2pkey
andcreate-cluster
commands tocreate enr
andcreate cluster
commands, i.e, subcommands of create command.category: refactor
ticket: #442
feature_set: stable