core/qbft: calculate q and f #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #503 +/- ##
==========================================
+ Coverage 56.44% 56.52% +0.07%
==========================================
Files 87 87
Lines 7979 7983 +4
==========================================
+ Hits 4504 4512 +8
+ Misses 2874 2871 -3
+ Partials 601 600 -1
Continue to review full report at Codecov.
|
xenowits
approved these changes
May 9, 2022
dB2510
approved these changes
May 9, 2022
| @@ -39,7 +39,7 @@ type Value[V any] interface { | |||
| type Transport[I any, V Value[V]] struct { | |||
| // Broadcast sends a message with the provided fields to all other | |||
| // processes in the system (including this process). | |||
| Broadcast func(typ MsgType, instance I, source int64, round int64, value V, pr int64, pv V, justify []Msg[I, V]) | |||
| Broadcast func(typ MsgType, instance I, source int64, round int64, value V, pr int64, pv V, justification []Msg[I, V]) | |||
There was a problem hiding this comment.
Maybe
Suggested change
| Broadcast func(typ MsgType, instance I, source int64, round int64, value V, pr int64, pv V, justification []Msg[I, V]) | |
| Broadcast func(typ MsgType, instance I, source int64, round int64, value V, pr int64, pv V, justifications []Msg[I, V]) |
There was a problem hiding this comment.
technically it is a single justification containing multiple messages...
| // Faulty is the maximum faulty process count for the system. | ||
| Faulty int | ||
| // Nodes is the total number of nodes/processes participating in consensus. | ||
| Nodes int |
OisinKyne
approved these changes
May 9, 2022
corverroos
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculates
QuorumandFaultyfromNodesas per Roberto suggestion. Also using his paper for the formulas.Also rename
justifytojustificationcategory: refactor
ticket: #445
feature_set: alpha