core/qbft: add drop tests and fix bugs #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #504 +/- ##
==========================================
+ Coverage 56.47% 56.49% +0.02%
==========================================
Files 87 87
Lines 7983 7989 +6
==========================================
+ Hits 4508 4513 +5
- Misses 2874 2878 +4
+ Partials 601 598 -3
Continue to review full report at Codecov.
|
OisinKyne
approved these changes
May 9, 2022
dB2510
approved these changes
May 10, 2022
Comment on lines
+202
to
+217
| // TODO(corver): Fix trimming. | ||
| // var selected []Msg[I, V] | ||
| // for _, msg := range buffer { | ||
| // if msg.Round() >= round-1 { | ||
| // selected = append(selected, msg) | ||
| // } | ||
| // } | ||
| // buffer = selected | ||
| // | ||
| // dedup := make(map[dedupKey]bool) | ||
| // for k := range dedupIn { | ||
| // if k.Round >= round { | ||
| // dedup[k] = true | ||
| // } | ||
| // } | ||
| // dedupIn = dedup |
There was a problem hiding this comment.
what is wrong with this approach? I assume there would be cases where we would need message of rounds before round-1
There was a problem hiding this comment.
We sometimes loose some PREPAREs from previous rounds, then we cannot trigger UnponQuorumRoundChange singe Qrc isn't justified. I have a plan to fix this in PR.
corverroos
force-pushed
the
corver/droptests
branch
from
43e8e82
to
485fcb3
Compare
corverroos
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the 10% dropped message test, which found some bugs:
preparedValue, only a single RC with that value (confirmed this with GoQuorumquorum/consensus/istanbul/qbft/core/justification.go:79).category: bug
ticket: #445
feature_set: alpha