core/consensus: add message signing #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #517 +/- ##
==========================================
- Coverage 55.45% 55.12% -0.34%
==========================================
Files 90 90
Lines 8318 8345 +27
==========================================
- Hits 4613 4600 -13
- Misses 3101 3136 +35
- Partials 604 609 +5
Continue to review full report at Codecov.
|
xenowits
approved these changes
May 11, 2022
xenowits
reviewed
May 11, 2022
core/consensus/msg.go
Outdated
| @@ -131,4 +134,41 @@ func hashProto(msg proto.Message) ([32]byte, error) { | |||
| return hash, nil | |||
| } | |||
|
|
|||
| // verifyMsgSig returns true if the message with signed by the pubkey. | |||
There was a problem hiding this comment.
Suggested change
| // verifyMsgSig returns true if the message with signed by the pubkey. | |
| // verifyMsgSig returns true if the message was signed by the same priv key. |
corverroos
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds message signing and verification helper functions for qbft consensus,
category: feature
ticket: #445
feature_flag: qbft_consensus