cmd: remove config flags from create cluster #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corverroos
force-pushed
the
corver/noconfig
branch
from
08d8a7f
to
c6b3007
Compare
Codecov Report
@@ Coverage Diff @@
## main #563 +/- ##
==========================================
- Coverage 54.42% 53.83% -0.60%
==========================================
Files 90 90
Lines 8577 8439 -138
==========================================
- Hits 4668 4543 -125
- Misses 3267 3271 +4
+ Partials 642 625 -17
Continue to review full report at Codecov.
|
xenowits
reviewed
May 20, 2022
xenowits
approved these changes
May 20, 2022
Co-authored-by: Abhishek Kumar <43061995+xenowits@users.noreply.github.com>
corverroos
force-pushed
the
corver/noconfig
branch
from
fa4a64b
to
522e991
Compare
corverroos
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes generated run scripts (and flags) from the charon create cluster.
category: refactor
ticket: #546