testutil/compose: add support for real vcs #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corverroos
commented
May 23, 2022
| b, err := static.ReadFile(path.Join(staticRoot, d.Name(), f.Name())) | ||
| if err != nil { | ||
| return errors.Wrap(err, "read file") | ||
| } | ||
|
|
||
| if err := os.WriteFile(path.Join(dir, d.Name(), f.Name()), b, info.Mode()); err != nil { |
There was a problem hiding this comment.
Can't use info.Mode() since that is 0o444 for embedded files.
| @@ -9,23 +9,23 @@ x-node-base: &node-base | |||
| {{if .Bootnode }}depends_on: [bootnode] {{end}} | |||
|
|
|||
| services: | |||
| {{ range $i, $node := .Nodes}} | |||
| {{- range $i, $node := .Nodes}} | |||
There was a problem hiding this comment.
fix spacing issues
Comment on lines
+68
to
+83
| var vcByType = map[vcType]vc{ | ||
| vcLighthouse: { | ||
| Label: string(vcLighthouse), | ||
| Build: "lighthouse", | ||
| }, | ||
| vcTeku: { | ||
| Label: string(vcTeku), | ||
| Image: "consensys/teku:latest", | ||
| Command: `| | ||
| validator-client | ||
| --network=auto | ||
| --beacon-node-api-endpoint="http://node1:16002" | ||
| --validator-keys="/compose/node1:/compose/node1" | ||
| --validators-proposer-default-fee-recipient="0x0000000000000000000000000000000000000000"`, | ||
| }, | ||
| } |
There was a problem hiding this comment.
this is the meat of the PR.
Codecov Report
@@ Coverage Diff @@
## main #595 +/- ##
==========================================
+ Coverage 54.16% 54.41% +0.24%
==========================================
Files 95 95
Lines 8922 8929 +7
==========================================
+ Hits 4833 4859 +26
+ Misses 3389 3376 -13
+ Partials 700 694 -6
Continue to review full report at Codecov.
|
corverroos
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for real VCs.
category: feature
ticket: #568