Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2p: implement naive p2p sender #666

Merged
merged 2 commits into from
Jun 5, 2022
Merged

p2p: implement naive p2p sender #666

merged 2 commits into from
Jun 5, 2022

Conversation

corverroos
Copy link
Contributor

@corverroos corverroos commented Jun 3, 2022

Implement v0 of the p2p sender. It doesn't do log filtering yet. This does however solve the issue of one node being down.

category: feature
ticket: #635

@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #666 (9541621) into main (48be2a6) will increase coverage by 0.22%.
The diff coverage is 8.33%.

@@            Coverage Diff             @@
##             main     #666      +/-   ##
==========================================
+ Coverage   54.55%   54.77%   +0.22%     
==========================================
  Files          98       99       +1     
  Lines        9517     9506      -11     
==========================================
+ Hits         5192     5207      +15     
+ Misses       3574     3558      -16     
+ Partials      751      741      -10     
Impacted Files Coverage Δ
p2p/sender.go 0.00% <0.00%> (ø)
core/parsigex/parsigex.go 46.29% <100.00%> (-18.08%) ⬇️
core/qbft/qbft.go 81.46% <0.00%> (+9.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48be2a6...9541621. Read the comment docs.

@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jun 5, 2022
@obol-bulldozer obol-bulldozer bot merged commit f9cfca3 into main Jun 5, 2022
@obol-bulldozer obol-bulldozer bot deleted the corver/p2psend branch June 5, 2022 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants