precommit: check log and error capitalisation #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corverroos
changed the title
corverroos
commented
Jun 10, 2022
| @@ -8,7 +8,7 @@ linters-settings: | |||
| default-signifies-exhaustive: true | |||
| forbidigo: | |||
| forbid: | |||
| - 'fmt\.Print.*' # Prevent debug logging | |||
| - 'fmt\.Print.*(# Avoid debug logging)?' | |||
There was a problem hiding this comment.
forbidigo supports UX messages inside regexp
There was a problem hiding this comment.
forbidigo only supports checking single identifiers. It cannot check function calls with arguments in a single regexp. So had write a custom regexp checker.
Codecov Report
@@ Coverage Diff @@
## main #693 +/- ##
==========================================
- Coverage 55.12% 55.11% -0.01%
==========================================
Files 102 102
Lines 9911 9899 -12
==========================================
- Hits 5463 5456 -7
+ Misses 3662 3653 -9
- Partials 786 790 +4
Continue to review full report at Codecov.
|
corverroos
changed the title
dB2510
approved these changes
Jun 10, 2022
corverroos
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds pre-commit hooks that checks:
category: misc
ticket: none