cmd/createdkg: verify enr in create dkg #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #757 +/- ##
==========================================
- Coverage 54.57% 54.38% -0.19%
==========================================
Files 107 107
Lines 10478 10485 +7
==========================================
- Hits 5718 5702 -16
- Misses 3919 3936 +17
- Partials 841 847 +6
Continue to review full report at Codecov.
|
corverroos
reviewed
Jul 1, 2022
cmd/createdkg.go
Outdated
| for i, opENR := range conf.OperatorENRs { | ||
| _, err := p2p.DecodeENR(opENR) | ||
| if err != nil { | ||
| return errors.Wrap(err, fmt.Sprintf("invalid ENR of operator %d", i)) |
There was a problem hiding this comment.
you should just be able to use z.Int("index",i)) instead of fmt.Sprintf
corverroos
approved these changes
Jul 1, 2022
dB2510
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verifies operator ENRs to be in standard form at the start of create dkg. Also make frost dkg as the default one.
category: refactor
ticket: #752