Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create dkg doensn't verify ENRs #752

Closed
OisinKyne opened this issue Jun 29, 2022 · 0 comments · Fixed by #757
Closed

create dkg doensn't verify ENRs #752

OisinKyne opened this issue Jun 29, 2022 · 0 comments · Fixed by #757

Comments

@OisinKyne
Copy link
Contributor

Problem to be solved

We managed to do a cluster creation with an invalid ENR supplied by Chris

Proposed solution

Don't let this happen, verify the legitimacy of ENRs before lettting create dkg process run

Out of Scope
@dB2510 dB2510 mentioned this issue Jun 30, 2022
Merged
@dB2510 dB2510 linked a pull request Jun 30, 2022 that will close this issue
cmd/createdkg: verify enr in create dkg #757
Merged
obol-bulldozer bot pushed a commit that referenced this issue Jul 2, 2022
@dB2510
cmd/createdkg: verify enr in create dkg (#757)
616f4da 
Verifies operator ENRs to be in standard form at the start of create dkg. Also make frost dkg as the default one.

category: refactor
ticket: #752
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmd/createdkg: verify enr in create dkg ObolNetwork/charon
1 participant
@OisinKyne