github: push charon to official docker hub registry #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #782 +/- ##
==========================================
+ Coverage 54.11% 54.50% +0.39%
==========================================
Files 109 109
Lines 10667 10667
==========================================
+ Hits 5772 5814 +42
+ Misses 4033 3991 -42
Partials 862 862
Continue to review full report at Codecov.
|
OisinKyne
changed the title
OisinKyne
changed the title
OisinKyne
changed the title
dB2510
approved these changes
Jul 11, 2022
corverroos
approved these changes
Jul 11, 2022
corverroos
reviewed
Jul 12, 2022
Comment on lines
61
to
67
| - uses: docker/build-push-action@v2 | ||
| with: | ||
| context: . | ||
| platforms: linux/amd64,linux/arm64 | ||
| push: true | ||
| build-args: GITHUB_SHA=${{ github.sha }} | ||
| tags: ${{ steps.meta.outputs.tags }} |
There was a problem hiding this comment.
It seems like multiple registries are supported by docker/build-push-action, so can remove this section and just move dockerhub login up next to ghcr login.
corverroos
approved these changes
Jul 12, 2022
corverroos
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushes the charon image to docker hub after ghcr. Needs to be tested by being merged. Potentially we don't want to send dev builds here too and might want to split this to only run on tags not commits to main.
category: misc
ticket: #781