Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/deadline: cleanup deadline.go #811

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Conversation

dB2510
Copy link
Contributor

@dB2510 dB2510 commented Jul 19, 2022

Addresses comments on earlier PR: #805

category: feature
ticket: #768

@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #811 (b41c3d0) into main (e8e092f) will increase coverage by 0.41%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #811      +/-   ##
==========================================
+ Coverage   54.43%   54.85%   +0.41%     
==========================================
  Files         109      109              
  Lines       10774    10772       -2     
==========================================
+ Hits         5865     5909      +44     
+ Misses       4044     3998      -46     
  Partials      865      865              
Impacted Files Coverage Δ
core/deadline.go 68.00% <100.00%> (-0.84%) ⬇️
core/qbft/qbft.go 81.54% <0.00%> (+9.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8e092f...b41c3d0. Read the comment docs.

@dB2510 dB2510 added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jul 19, 2022
@obol-bulldozer obol-bulldozer bot merged commit 588181d into main Jul 19, 2022
@obol-bulldozer obol-bulldozer bot deleted the dhruv/cleandeadliner branch July 19, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants